Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customized multi-IdP behavior #253

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Customized multi-IdP behavior #253

merged 2 commits into from
Jul 15, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jul 11, 2024

Changed

  • Patch the standard SP AuthSource to modify behavior when multiple IdPs are available for an SP.
    • When more than one IdP is available, always present the discovery page. Standard behavior is to proceed using an existing IdP session if possible.
    • When re-authentication is required, always present the discovery page. Standard behavior is to let the user choose whether to cancel or continue.

Fixed

  • Fixed the SingleLogoutService on the test IdPs to use the standard saml2-logout.php since it no longer needs to be customized.

Note: these customizations were done differently in ssp-base v9 (pre-SSP2). See sections marked "GTIS" in this file for reference.

@briskt
add context to patch file sp-php.patch
205e1f2 
From the diff man page: "For proper operation, patch typically needs at least two lines of context"
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@briskt briskt merged commit 3ee5ce9 into develop Jul 15, 2024
3 checks passed
@briskt briskt deleted the feature/ssp2-sp-patch branch July 15, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-jackson jason-jackson jason-jackson left review comments

@forevermatt forevermatt forevermatt approved these changes

@mtompset mtompset Awaiting requested review from mtompset

@hobbitronics hobbitronics Awaiting requested review from hobbitronics

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briskt @forevermatt @jason-jackson